The case of editing logic function usage.

konstantin_shiriazdanov

Im' trying to automate the process of getting mate connectors owned by selected bodies into the list input ( with options to define some associated orientation data from enum parameter). But seems like when editing logic function is set the feature treats my attempt to edit list input parameter as a signal to refresh input field. Am I doing something wrong?

Here is the feature https://cad.onshape.com/documents/dac32e8d473681a47870141f/w/6061a9a3ea3fe56c74a037fb/e/1bee88dc7878a28fe9eaf056

The editing logic function looks like this:

export function modifyMCArr(context is Context, id is Id, oldDefinition is map, definition is map, isCreating is boolean, specifiedParameters is map) returns map
{
    var partsMCQueries = qMateConnectorsOfParts(oldDefinition.parts)->qOwnedByBody(EntityType.VERTEX);

    if (isCreating/* && !specifiedParameters.MCs*/)
    {
        definition.MCs = [];
        for (var MC in evaluateQuery(context, partsMCQueries))
        {
            definition.MCs = append(definition.MCs, { "query" : MC, "orientation" : CoordSystemOrientation.ZERO });
        }
        return definition;
    }

}

https://youtu.be/lTCn51WofHA

MBartlett21

@konstantin_shiriazdanov
Did you mean to use 'oldDefinition' where you check the parts?
Also, if isCreating is false, your function does not live up to its promise of always returning a `map`.

kevin_o_toole_1

Anything you return from an editing logic function will be used the new value. If you want the result after your change to keep some of the old values inside the old definition.MCs, you will need to insert those values onto the return value somehow.

This involves your function settling on an answer to what happens when the sizes or content of definition.MCs and partsMCQueries differ.

konstantin_shiriazdanov

@kevin_o_toole_1 I think I don't qute understand from the documentation what triggers edit logic function evaluation? is it any change in definition while feature dialog is open? and if the answer is "yes" what state of input is treated as oldDefinition and definition? before and after the edit?

@MBartlett21 I was just trying to workout the case when feature is just created and actually can't advance any farther.

upd: So the right test to find out if the certain input field is edited by user during feature creation seem to be pretty tricky

kevin_o_toole_1

@konstantin_shiriazdanov
Correct. Editing logic is called after every user change. oldDefinition contains the parameter values before the change, definition contains the parameter values after the change.

If you want your editing logic to only run when a certain parameter changes, you can simply add logic like

if (oldDefinition.parts != definition.parts)
{
   // change definition.MCs and return modified version
}