The most difficult thing in Onshape is rounding a valueWithUnits

joshtargo

Am i going crazy or is there no way to name a part by a rounded valueWithUnits in the user's own workspace units?

Konst_Sh

yes, thats not a one-line solution, you would have to use roundToPrecision() but it only works for real numbers, so you divide it by unit, round the unitless value to precision, and compose a string of that value and unit name string

joshtargo

https://forum.onshape.com/discussion/comment/120334#Comment_120334

but i want the string to be in the user's workspace units

_anton

Custom feature execution can't know about workspace units - otherwise, we'd have to regenerate the entire thing any time you change those. The workspace units are basically just for display. If custom feature code determines a part name, it can't depend on workspace units.

You could have your part-naming feature take units and a precision in the UI, and round to that?

MichaelPascoe

There is a way you can get the current workspace units at the time you insert the feature. I learned this trick from Kevin:

https://cad.onshape.com/documents/e0c13dc3836c7dcba155622a/w/c3a138bc21a0284d4afbea62/e/a2290d1b855aec5d8f5af6f3…

Get the current default units when the feature is inserted. This input will default to 1 of whichever units the document is currently using at the time. Note that it only does it when you first insert the feature.

annotation { "Name" : "Invisible length", "UIHint" : UIHint.ALWAYS_HIDDEN }
            isLength(definition.lengthUnit, {
                            (inch) : [-10000, 1.0, 10000],
                            (meter) : 1,
                            (centimeter) : 1,
                            (millimeter) : 1,
                            (foot) : 1,
                            (yard) : 1 } as LengthBoundSpec);

and then, convert and round. Now that I'm looking at this next part, the switch statement might be redundant since the lengthUnit is already a resulting unit.

//get document units
    var resultUnit = switch (lengthUnit) {
            (inch) : inch,
            (meter) : meter,
            (centimeter) : centimeter,
            (millimeter) : millimeter,
            (foot) : foot,
            (yard) : yard,
        };

    var unitlessResult = distance / resultUnit;

    if (rounding)
    {
        distance = round(unitlessResult, roundingPrecision) * resultUnit;
    }

joshtargo

https://forum.onshape.com/discussion/comment/120338#Comment_120338

thank you. maybe one day there will be getWorkspaceUnits or smth.

EDIT, actually it doesn't work, it's giving me meters always, even though my workspace units are inches.

joshtargo

this did it:

export function getWorkspaceUnits(definition is map) returns map
{

/*
    In precondition area:
    
    annotation { "Name" : "Length Unit", "UIHint" : UIHint.ALWAYS_HIDDEN }
        isLength(definition.lengthUnit, {
            (inch) : [-10000, 1.0, 10000],
            (meter) : 1,
            (centimeter) : 1,
            (millimeter) : 1,
            (foot) : 1,
            (yard) : 1 } as LengthBoundSpec);

    Usage:
    
    const wsu = getWorkspaceUnits(definition);
    var unitlessLength = length / wsu.unit;
    outputString = toString(roundToPrecision(unitlessLength,3))~" "~wsu.unitText;

*/

    var resultUnit = definition.lengthUnit;
    var unit;
    var unitText;

    if(tolerantEquals(resultUnit, 0.0254 * meter)){ unit = inch;       unitText = "inch";} 
    if(tolerantEquals(resultUnit,      1 * meter)){ unit = meter;      unitText = "meter";} 
    if(tolerantEquals(resultUnit,   0.01 * meter)){ unit = centimeter; unitText = "centimeter";} 
    if(tolerantEquals(resultUnit,  0.001 * meter)){ unit = millimeter; unitText = "millimeter";}

    var workspaceUnits = {"unit" : unit, "unitText" : unitText};
    
    return workspaceUnits;

}