opBoolean fails with invalid input

brad_phelan

I'm developing my autoRib feature at

https://cad.onshape.com/documents/83f268820b92e08f4f30db06/w/ec7ac3c9e66d4c5dc475d388/e/aadea257f248d95c6631d7d5

The cylinder is the original part and the rectangular box is a solid generated half way through the script. I wish to opBoolean::Intersect these two. However opBoolean fails with INVALID_INPUT and I am mystified as to why.





I have tried to make the code robust by ensuring only solids go to the opBoolean operation.

    var qr0 = qBodyType(qCreatedBy(id, EntityType.BODY), BodyType.SOLID);

    var qr1 = qBodyType(entities, BodyType.SOLID);

    

    var qq = qUnion([qr0,qr1]);

    

    // This outputs 1 Solid and 1 Face (weird)

    debug(context,qq);

   

    opBoolean(context, id + "boolean1", {

            "tools" : qq ,

            "operationType" : BooleanOperationType.INTERSECTION

    });

however debug outputs

Query resolves to 1 bodies, 1 faces

If I do an opDelete on qq then the cylinder and the box are removed.

What could be going wrong.

Source code for opRibFromPlane is at

https://cad.onshape.com/documents/83f268820b92e08f4f30db06/w/ec7ac3c9e66d4c5dc475d388/e/e85455e9a0f5ab76faab2043

konstantin_shiriazdanov

in line 84 you have: var qr0 = qBodyType(qCreatedBy(id, EntityType.BODY), BodyType.SOLID);
possibly you need: var qr0 = qBodyType(qCreatedBy(id + "extrude1", EntityType.BODY), BodyType.SOLID);

brad_phelan

My fault.

I had passed in a face to the function ( as selected in the feature ) instead of a part.

However why does

   var qr1 = qBodyType(entities, BodyType.SOLID);

still return a result in the query.

konstantin_shiriazdanov

by the way I finaly managed to do unfold feature for developable extracted surfaces
https://cad.onshape.com/documents/ce8000dae12df34ec634041e/w/7a822b306bad8b1d8c55b7b9/e/e325cc4f8612678591a39cf4

Jake_Rosenfeld

Hi @brad_phelan ,

qBodyType doesn't do what you're expecting it to do.  qBodyType(query, BodyType.SOLID) will query for all entities of 'query' that are either a) solid bodies or b) belong to solid bodies.  So, as long as your selected face belonged to a solid body it would bass the body type test.

I think the query you're looking for is:

qEntityFilter(entities, EntityType.BODY)

or 

qBodyType(qEntityFilter(entities, EntityType.BODY), BodyType.SOLID)

if you want to be extra careful about only getting solid bodies.


Also, just as a FeatureScript note, your utility functions (fPatternPlanes, fBoundingPlanes, opRibFromPlane, etc) don't need to be 'export'ed unless you want to use them in another FeatureScript file, and don't need an 'annotation {}' at all. You can use 'print(...)' or 'println(...)' instead of 'debug(...)' if you want to print strings or see the content of variables that aren't 'Query's.

Edit: I would also try to avoid using dummyQuery.  It looks like what you're trying to do can be accomplished with 'qCreatedBy(...)'

brad_phelan

@konstantin_shiriazdanov yay. I'll check that out soon.

@Jake_Rosenfeld thanks for those tips. I'll fold the advice in.