FeatureScript smooth edges

MBartlett21

in FeatureScript, I would like to make my own error message instead of the one generated by opFillet();.

I have written this function to fillet all the edges in a model except the ones that are specified.

https://cad.onshape.com/documents/b7252b2d8824c81fa19efffe/w/62f20e91708c14f2b8e1330f/e/47f23a63404badcd4649270d

I would like it to say that there are no edges that it can fillet if all the edges are smooth

paul_chastell

If I were to do this I would use evEdgeConvexity. Here's some psuedo-code (I skip passing contexts and other such stuff). Assuming you are doing

opFillet(edgeQuery)

I would do something like this:

nonSmooth = false<br>edges = evaluateQuery(edgeQuery)<br>for each edge in edges:<br>&nbsp; &nbsp; if evEdgeConvexity(edge) != SMOOTH:<br>&nbsp; &nbsp; &nbsp; &nbsp; nonSmooth = true<br>if nonSmooth:<br>&nbsp; &nbsp; opFillet(edgeQuery)<br>else:<br>&nbsp; &nbsp; throw regenError("All edges are smooth")

MBartlett21

@paul_chastell

I have redone the feature.

annotation { "Feature Type Name" : "Fillet Everything" }
export const filletEverything = defineFeature(function(context is Context, id is Id, definition is map)
    precondition
    {
        annotation { "Name" : "Fillet radius" }
        isLength(definition.filletRadius, BLEND_BOUNDS);

        annotation { "Name" : "Don't Fillet", "Filter" : EntityType.EDGE || EntityType.FACE }
        definition.noFillet is Query;
    }
    {
        
        //This is the edges that will be filleted
        const edgesToFillet = qSubtraction(
                qSubtraction(
                    qBodyType(
                        qEverything(
                            EntityType.EDGE
                        ),
                        BodyType.SOLID
                    ),
                    qEntityFilter(
                        definition.noFillet,
                        EntityType.EDGE
                    )
                ),
                qEdgeAdjacent(
                    qEntityFilter(
                        definition.noFillet,
                        EntityType.FACE
                    ),
                    EntityType.EDGE
                )
            );
            
        //This boolean tells the feature whether the edges are smooth or not
        var smooth is boolean = true;

        var edges = evaluateQuery(
            context, edgesToFillet
        );
        
        //This for loop detects whether edges are smooth
        for (var edge in edges)
        {
            //This detects whether the selected edge is smooth or not
            if (evEdgeConvexity(
                        context, {
                            "edge" : edge
                        }) != EdgeConvexityType.SMOOTH)
            {
                smooth = false;
                break;
            }
        }
        if (!smooth)
        {
            opFillet(
                    context, id + "fillet1",
                    {
                        "entities" : edgesToFillet,
                        "radius" : definition.filletRadius
                    }
                );
        }
        else
        {
            throw regenError("There are no sharp edges that can be filleted.");
        }
    });

paul_chastell

Nice.

paul_chastell

If I were to do this I would use evEdgeConvexity. Here's some psuedo-code (I skip passing contexts and other such stuff). Assuming you are doing

opFillet(edgeQuery)

I would do something like this:

nonSmooth = false<br>edges = evaluateQuery(edgeQuery)<br>for each edge in edges:<br>&nbsp; &nbsp; if evEdgeConvexity(edge) != SMOOTH:<br>&nbsp; &nbsp; &nbsp; &nbsp; nonSmooth = true<br>if nonSmooth:<br>&nbsp; &nbsp; opFillet(edgeQuery)<br>else:<br>&nbsp; &nbsp; throw regenError("All edges are smooth")

MBartlett21

@paul_chastell

Thanks!

MBartlett21

@paul_chastell

Here is what I was doing: 

opFillet(context, id + "fillet1",
                { "entities" :
                        qSubtraction(
                            qSubtraction(
                                qBodyType(
                                    qEverything(
                                        EntityType.EDGE
                                    ),
                                    BodyType.SOLID
                                ),
                                qEntityFilter(
                                    definition.noFillet,
                                    EntityType.EDGE
                                )
                            ),
                            qEdgeAdjacent(
                                qEntityFilter(
                                    definition.noFillet,
                                    EntityType.FACE
                                ),
                                EntityType.EDGE
                            )
                        ),
                    "radius" : definition.filletRadius
                });

definition.noFillet is the faces and edges not to fillet.

MBartlett21

@paul_chastell

I have redone the feature.

annotation { "Feature Type Name" : "Fillet Everything" }
export const filletEverything = defineFeature(function(context is Context, id is Id, definition is map)
    precondition
    {
        annotation { "Name" : "Fillet radius" }
        isLength(definition.filletRadius, BLEND_BOUNDS);

        annotation { "Name" : "Don't Fillet", "Filter" : EntityType.EDGE || EntityType.FACE }
        definition.noFillet is Query;
    }
    {
        
        //This is the edges that will be filleted
        const edgesToFillet = qSubtraction(
                qSubtraction(
                    qBodyType(
                        qEverything(
                            EntityType.EDGE
                        ),
                        BodyType.SOLID
                    ),
                    qEntityFilter(
                        definition.noFillet,
                        EntityType.EDGE
                    )
                ),
                qEdgeAdjacent(
                    qEntityFilter(
                        definition.noFillet,
                        EntityType.FACE
                    ),
                    EntityType.EDGE
                )
            );
            
        //This boolean tells the feature whether the edges are smooth or not
        var smooth is boolean = true;

        var edges = evaluateQuery(
            context, edgesToFillet
        );
        
        //This for loop detects whether edges are smooth
        for (var edge in edges)
        {
            //This detects whether the selected edge is smooth or not
            if (evEdgeConvexity(
                        context, {
                            "edge" : edge
                        }) != EdgeConvexityType.SMOOTH)
            {
                smooth = false;
                break;
            }
        }
        if (!smooth)
        {
            opFillet(
                    context, id + "fillet1",
                    {
                        "entities" : edgesToFillet,
                        "radius" : definition.filletRadius
                    }
                );
        }
        else
        {
            throw regenError("There are no sharp edges that can be filleted.");
        }
    });

paul_chastell

Nice.