GeometryType.OTHER_CURVE error

nir_naron

 Error is something along the lines of “OTHER_CURVE” not being a valid geometry type. The FeatureScript documentation describes it fully, so I’m not sure what am I missing.

I want the input to be an ellipse. If anyone has any idea about how to get it done, you have a shoutout reserved in the script’s documentation!

NeilCooke

Looks like it can only be used in conjunction with qGeometry. Not sure why. You could certainly check for an ellipse using qGeometry and then throw a regenError - not very user friendly though.

NeilCooke

In the body of the code, you would have to do something like:

FeatureScript 2221;
import(path : "onshape/std/common.fs", version : "2221.0");

annotation { "Feature Type Name" : "My Feature" }
export const myFeature = defineFeature(function(context is Context, id is Id, definition is map)
    precondition
    {
        annotation { "Name" : "Ellipse", "Filter" : EntityType.EDGE, "MaxNumberOfPicks" : 1 }
        definition.ellipse is Query;

        annotation { "Name" : "Rad" }
        isLength(definition.radius, LENGTH_BOUNDS);
    }
    {
        const ellipse = evCurveDefinition(context, {
                    "edge" : definition.ellipse
                });

        if (ellipse.coordSystem == undefined || isQueryEmpty(context, qGeometry(definition.ellipse, GeometryType.OTHER_CURVE)))
            throw regenError("Must select an ellipse", definition.ellipse); 

        const sketch = newSketchOnPlane(context, id + "sketch1", {
                    "sketchPlane" : plane(ellipse.coordSystem.origin, ellipse.coordSystem.xAxis, ellipse.coordSystem.zAxis)
                });

        skCircle(sketch, "circle", {
                    "center" : vector(0, 0) * meter,
                    "radius" : definition.radius
                });

        skSolve(sketch);
    });

You can still get the ellipse center using evCurveDefinition.

NeilCooke

It's just good practice if you don't want to accidentally overwrite a variable further down in your code. If you want to reuse a variable or update it, use var.

NeilCooke

Looks like it can only be used in conjunction with qGeometry. Not sure why. You could certainly check for an ellipse using qGeometry and then throw a regenError - not very user friendly though.

nir_naron

NeilCooke said:

Looks like it can only be used in conjunction with qGeometry. Not sure why. You could certainly check for an ellipse using qGeometry and then throw a regenError - not very user friendly though.

Thanks! Will you specify how to implement your suggestion? I tried using qGeometry and didn’t manage 

NeilCooke

In the body of the code, you would have to do something like:

FeatureScript 2221;
import(path : "onshape/std/common.fs", version : "2221.0");

annotation { "Feature Type Name" : "My Feature" }
export const myFeature = defineFeature(function(context is Context, id is Id, definition is map)
    precondition
    {
        annotation { "Name" : "Ellipse", "Filter" : EntityType.EDGE, "MaxNumberOfPicks" : 1 }
        definition.ellipse is Query;

        annotation { "Name" : "Rad" }
        isLength(definition.radius, LENGTH_BOUNDS);
    }
    {
        const ellipse = evCurveDefinition(context, {
                    "edge" : definition.ellipse
                });

        if (ellipse.coordSystem == undefined || isQueryEmpty(context, qGeometry(definition.ellipse, GeometryType.OTHER_CURVE)))
            throw regenError("Must select an ellipse", definition.ellipse); 

        const sketch = newSketchOnPlane(context, id + "sketch1", {
                    "sketchPlane" : plane(ellipse.coordSystem.origin, ellipse.coordSystem.xAxis, ellipse.coordSystem.zAxis)
                });

        skCircle(sketch, "circle", {
                    "center" : vector(0, 0) * meter,
                    "radius" : definition.radius
                });

        skSolve(sketch);
    });

You can still get the ellipse center using evCurveDefinition.

nir_naron

NeilCooke said:

In the body of the code, you would have to do something like:

FeatureScript 2221;
import(path : "onshape/std/common.fs", version : "2221.0");

annotation { "Feature Type Name" : "My Feature" }
export const myFeature = defineFeature(function(context is Context, id is Id, definition is map)
    precondition
    {
        annotation { "Name" : "Ellipse", "Filter" : EntityType.EDGE, "MaxNumberOfPicks" : 1 }
        definition.ellipse is Query;

        annotation { "Name" : "Rad" }
        isLength(definition.radius, LENGTH_BOUNDS);
    }
    {
        const ellipse = evCurveDefinition(context, {
                    "edge" : definition.ellipse
                });

        if (ellipse.coordSystem == undefined || isQueryEmpty(context, qGeometry(definition.ellipse, GeometryType.OTHER_CURVE)))
            throw regenError("Must select an ellipse", definition.ellipse); 

        const sketch = newSketchOnPlane(context, id + "sketch1", {
                    "sketchPlane" : plane(ellipse.coordSystem.origin, ellipse.coordSystem.xAxis, ellipse.coordSystem.zAxis)
                });

        skCircle(sketch, "circle", {
                    "center" : vector(0, 0) * meter,
                    "radius" : definition.radius
                });

        skSolve(sketch);
    });

You can still get the ellipse center using evCurveDefinition.

Thanks so much! When does one use “const” as opposed to “var”?

NeilCooke

It's just good practice if you don't want to accidentally overwrite a variable further down in your code. If you want to reuse a variable or update it, use var.