Query for entities to boolean

ben_partouch

Hi,
I'm trying to boolean subtract bodies created with oppattern inside a for loop. Not sure what I should do...

Thank you!

doc:
https://cad.onshape.com/documents/ef3ba98102efc6b4e4c71194/w/50cf1b58a05a4b7c535589fd/e/8c530af3038d5e69dbf7c755

for (var i = -1; i < definition.numberOfHoles - 1; i += 1)

        {

            const computedTransforms1 = transform((vector(0 * centimeter, 0 * centimeter, definition.holeSpacing)) * (i + 1));

            opPattern(context, id + ("patternB" ~ i), {

                        "entities" : qCreatedBy(id + "extrude1", EntityType.FACE),

                        "transforms" : [computedTransforms1],

                        "instanceNames" : ["Holes"]

                    });

            // opBoolean(context, id + "boolean2", {

            //             "tools" : qCreatedBy(id + ("patternB" ~ i), EntityType.BODY),

            //             "targets" : definition.panels,

            //             "operationType" : BooleanOperationType.SUBTRACTION

            //         });

        }

Jacob_Corder

Change your pattern to EntityType.BODY not EntityType.FACE

opPattern(context, id + ("patternB" ~ i), {

                        "entities" : qCreatedBy(id + "extrude1", EntityType.BODY),

                        "transforms" : [computedTransforms1],

                        "instanceNames" : ["Holes"]

                    });

ben_partouch

Thanks @Jacob_Corder.

Looks like it can stay FACE but my id was wrong. Now- opBoolean(context, id + ("boolean2" ~ i).
Seems to work:)

NeilCooke

For speed, build an array of transforms and names in the for loop then do opPattern and opBoolean once. Our servers will thank you. 

ben_partouch

Thanks @NeilCooke. 
I would love to take you advice but my capabilities in FS are so amature and limited that I have no idea how to do what you suggested LOL.
My code is so inefficient. Would love to learn how to get better at this!

Evan_Reese

He means something like this. I've not tested this code, but the idea is there if not the functionality.

//for loop for drilled holes
        var computedTransforms1 = []; // make an empty array to later store transforms
        var instanceNames = []; // make an empty array to later store instance names<br>
        for (var i = -1; i < definition.numberOfHoles - 1; i += 1)
        {
            const computedTransform = transform((vector(0 * centimeter, 0 * centimeter, definition.holeSpacing)) * (i + 1));
            computedTransforms1 = append(computedTransforms1, computedTransform); // add the new transform to the array
            instanceNames = append(instanceNames, "hole"~toString(i)); // add the new instance name to the array<br>
        }
// no more need to add + i to the Id's here since you only call the functions once.
            opPattern(context, id + "patternB", {
                        "entities" : qCreatedBy(id + "extrude1", EntityType.FACE),
                        "transforms" : computedTransforms1,
                        "instanceNames" : ["Holes"]
                    });

            opBoolean(context, id + "boolean2", {
                        "tools" : qCreatedBy(id + "patternB", EntityType.BODY),
                        "targets" : definition.panels,
                        "operationType" : BooleanOperationType.SUBTRACTION
                    });

ben_partouch

I'll give it a shot! Thanks guys.

ben_partouch

Couldn't make it to work. 
Thanks for looking into it:)

NeilCooke

ben_partouch said:

Couldn't make it to work. 
Thanks for looking into it:)

Which bit is failing?

ben_partouch

@neilCooke

@opPattern: INVALID_INPUT

NeilCooke

opPattern(context, id + "patternB", {
                    "entities" : qCreatedBy(id + "extrude1", EntityType.BODY),
                    "transforms" : computedTransforms1,
                    "instanceNames" : instanceNames
                });

ben_partouch

Should have seen this one!..... Thank you @NeilCooke!

Evan_Reese

ben_partouch said:

Should have seen this one!..... Thank you @NeilCooke!

Oops. That's on me. Glad you got it working.