Grid Extrude Custom Feature

Comments

• m_h2 Member Posts: 2 ✭

  March 19

  @EvanReese
  
  If have some Issues with your feature… I can't generate the grid on this sketch… could you helpt me?
  
  

  

  0
• EvanReese Member, Mentor Posts: 2,670 PRO

  March 20 edited March 20

  is the rectangle possibly smaller than 25mm? Try reducing the cell width. Beyond that I'd need to get into the document to check it out if you can share it.

  Evan Reese
  The Onsherpa | Reach peak Onshape productivity
  www.theonsherpa.com

  0
• william_knoblauch Member Posts: 18 ✭✭

  November 14

  Hey Evan,

  I recently found an issue with your script when trying to make a grid that subtracts from a part. I'm getting these weird fillets at the border of the pattern.

  

  It doesn't seem to be a systemic problem. It just happens when inverting the grid with a border and corner radius. Here are the settings I'm using:

  

  I'm pretty sure it's just the fillet query for the edges of the boundary.

  if (!tolerantEquals(definition.cornerRadius, 0 * meter) && !isCircleHex && !isCicleSq)
              {
                  const moreToFillet = qUnion([qNonCapEntity(id + "boundary", EntityType.EDGE), qCreatedBy(id + "boundaryBoolean", EntityType.EDGE)]);
                  opFillet(context, id + "fillet2", {
                              "entities" : moreToFillet,
                              "radius" : definition.cornerRadius
                          });
              }
  

  Restricting the queried edges to follow the direction of the extrude works, but there are still some edges that fail. (That's why I added try{} because opFillet() seems to fail even if you just look at it wrong)

  if (!tolerantEquals(definition.cornerRadius, 0 * meter) && !isCircleHex && !isCicleSq)
              {
                  const moreToFillet = qUnion([qParallelEdges(qNonCapEntity(id + "boundary", EntityType.EDGE), direction), qParallelEdges(qCreatedBy(id + "boundaryBoolean", EntityType.EDGE), direction)]);
                  try {
                  opFillet(context, id + "fillet2", {
                              "entities" : moreToFillet,
                              "radius" : definition.cornerRadius
                          });
                   }
              }
  
  

  I made a copy of your document and added those qParallelEdges() functions, and it works pretty well when doing what I wanted. The fillets fail when making a new part with a boundary, but with the original query, the whole script fails anyway.

  Thanks for the awesome script!

  0
• EvanReese Member, Mentor Posts: 2,670 PRO

  November 14

  https://forum.onshape.com/discussion/comment/123269#Comment_123269

  Thanks! I appreciate you troubleshooting. I'll put it on my (fairly long) list of things to do

  Evan Reese
  The Onsherpa | Reach peak Onshape productivity
  www.theonsherpa.com

  1